Raise ValueError when Domain has no values #5086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
domain_update
branch
from
dea0211 to
0a37f3a
Compare
Codecov Report
@@ Coverage Diff @@
## main #5086 +/- ##
=======================================
Coverage 75.10% 75.10%
=======================================
Files 87 87
Lines 14142 14142
=======================================
+ Hits 10621 10622 +1
+ Misses 3521 3520 -1
|
ricardoV94
force-pushed
the
domain_update
branch
from
0a37f3a to
2361301
Compare
Member
Author
|
This seems to have caught some parameterizations that were not actually being tested in the ordered dists |
twiecki
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to make the
Domaintest helper a bit more user friendly.Situation appeared in #5085