Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Gumbel Distribution is incorrectly described #6478

Closed
wants to merge 1 commit into from
Closed

The Gumbel Distribution is incorrectly described #6478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pymc/distributions/continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2985,7 +2985,9 @@ def triangular_default_transform(op, rv):

class Gumbel(Continuous):
r"""
Univariate Gumbel log-likelihood.
Univariate Gumbel right Skew log-likelihood. This parameterization will provide the extrem maximum value.
Those looking to find the extrem minimum provided by the left skew Gumbel should
invert the sign to all X and Y values (positive to negative and negative to positive).
Comment on lines +2988 to +2990
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Univariate Gumbel right Skew log-likelihood. This parameterization will provide the extrem maximum value.
Those looking to find the extrem minimum provided by the left skew Gumbel should
invert the sign to all X and Y values (positive to negative and negative to positive).
Univariate Gumbel right Skew log-likelihood. This parameterization will provide the extreme maximum value.
Those looking to find the extreme minimum provided by the left skewed Gumbel should
invert the sign to all X and Y values (positive to negative and negative to positive).

fixes two typos and removes trailing whitespace which our pre-commit would complain about

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs to be formatted as 1st sentence, a white line and then the more extense description to follow numpydoc: https://numpydoc.readthedocs.io/en/latest/format.html#sections

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell, sorry for not looking at these comments. I am dealing with wedding planning and work at the same time. will look into this around the end of February.


The pdf of this distribution is

Expand Down