Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider dims without coords volatile if length has not changed #7381

Merged
merged 8 commits into from
Jul 7, 2024
Merged

Do not consider dims without coords volatile if length has not changed #7381

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eeb4e12
compare coord length if no values
JasonTam Jun 21, 2024
b859845
pull out function `get_constant_coords` fn and add test
JasonTam Jun 26, 2024
e7264e2
include value coord in test
JasonTam Jun 26, 2024
694660c
type check instead of attr check
JasonTam Jun 30, 2024
d40fffe
add integration test
JasonTam Jun 30, 2024
49bbf8c
also test if trace has same len but dim set to diff len
JasonTam Jul 5, 2024
13d3aef
fix merge conflict
JasonTam Jul 5, 2024
b76087d
comment wording
JasonTam Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pymc/sampling/forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,10 +795,17 @@ def sample_posterior_predictive(
constant_coords = set()
for dim, coord in trace_coords.items():
current_coord = model.coords.get(dim, None)
current_length = model.dim_lengths.get(dim, None)
if hasattr(current_length, 'eval'):
current_length = current_length.eval()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can only be a shared variable in which case you can retrieve with get_value(), or a Constant in which case you can retrieve with .data That should be much more efficient than eval unless eval does something clever under the hood

if (
current_coord is not None
and len(coord) == len(current_coord)
and np.all(coord == current_coord)
) or (
# Coord was defined without values (only length)
current_coord is None
and len(coord) == current_length
):
constant_coords.add(dim)

Expand Down
Loading