Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some type hinting to help with migrating Distribution #7484

Merged
merged 8 commits into from
Oct 9, 2024
Merged

Fix some type hinting to help with migrating Distribution #7484

merged 8 commits into from
Oct 9, 2024
+15 −8

Commits on Sep 4, 2024

  1. Type get_tau_sigma correctly and fix comment

    @thomasaarholt
    thomasaarholt committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    85784b8 View commit details
    Browse the repository at this point in the history

  2. Fix tuple type 

    Use of bound_arg_indices shows that this should be a (start, end) tuple, not a list.
    @thomasaarholt
    thomasaarholt committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8ea8b6c View commit details
    Browse the repository at this point in the history

  3. Fix incorrect type hinting syntax 

    I don't want to touch the `= None` part. I could add ` | None`
to the type hint but I suspect the `= None` is unnecessary.
    @thomasaarholt
    thomasaarholt committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b2692ea View commit details
    Browse the repository at this point in the history

  4. Type rv_op based on behaviour rather than type 

    This is a bit like using a Protocol class, we say that whatever
is passed to rv_op, it should return a TensorVariable.
    @thomasaarholt
    thomasaarholt committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    af91def View commit details
    Browse the repository at this point in the history

  5. Try removing Optional / = None completely 

    I don't think these are necessary at all. The tests will tell us so.
    @thomasaarholt
    thomasaarholt committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2e84b30 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Try setting rv_op: Any = None

    @thomasaarholt
    thomasaarholt committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    157c29a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Remove debug statement

    @thomasaarholt
    thomasaarholt committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7bd35a8 View commit details
    Browse the repository at this point in the history

  2. Correct type definition for bound_arg_indices 

    Allows optional lower or upper bounds.
    @thomasaarholt
    thomasaarholt committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1575243 View commit details
    Browse the repository at this point in the history