Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mean dispatch for pymc distributions #7530

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

lucianopaz
Copy link
Contributor

@lucianopaz lucianopaz commented Oct 9, 2024

Description

This PR provides a single dispatch protocol that computes the expected value of most pymc distributions.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7530.org.readthedocs.build/en/7530/

@lucianopaz
Copy link
Contributor Author

@ricardoV94, I finally decided to put some time and port this stuff into pymc

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (938aff4) to head (1c71deb).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7530      +/-   ##
==========================================
+ Coverage   92.69%   92.81%   +0.11%     
==========================================
  Files         104      106       +2     
  Lines       17409    17644     +235     
==========================================
+ Hits        16138    16376     +238     
+ Misses       1271     1268       -3     
Files with missing lines Coverage Δ
pymc/distributions/moments/__init__.py 100.00% <100.00%> (ø)
pymc/distributions/moments/means.py 100.00% <100.00%> (ø)
pymc/exceptions.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Small change requests commented above

@ricardoV94 ricardoV94 merged commit 54f7101 into pymc-devs:main Oct 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants