Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add non_dimension_coords to MDAEvent #216

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Feb 24, 2025

closes #196, allowing for additional coordinates to be attached to an MDAEvent, that are a "true axis" of the sequence. For example, in a well plate where you have selected 12 wells, you will see index = {"p": 0 } ... {"p": 11} but each position will now also have non_dimension_coords with something like: {"r": 0, "c": 1}.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.72%. Comparing base (0787a89) to head (77c601a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/useq/_iter_sequence.py 66.66% 5 Missing ⚠️
src/useq/_mda_event.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   94.03%   93.72%   -0.31%     
==========================================
  Files          22       22              
  Lines        1492     1515      +23     
==========================================
+ Hits         1403     1420      +17     
- Misses         89       95       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: possibly add non-dimension coordinates to the MDAEvent
1 participant