Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #266

Merged
merged 49 commits into from
May 7, 2024
Merged

Dev #266

merged 49 commits into from
May 7, 2024

Conversation

gviejo
Copy link
Contributor

@gviejo gviejo commented Apr 11, 2024

Adding core_functions.py to dispatch calls to numba core functions or pynajax

@coveralls
Copy link

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8651925570

Details

  • 60 of 187 (32.09%) changed or added relevant lines in 11 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 84.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynapple/core/interval_set.py 1 2 50.0%
pynapple/process/correlograms.py 1 5 20.0%
pynapple/core/config.py 13 18 72.22%
pynapple/core/base_class.py 10 16 62.5%
pynapple/core/utils.py 10 25 40.0%
pynapple/core/time_series.py 5 32 15.63%
pynapple/core/core_function.py 15 84 17.86%
Files with Coverage Reduction New Missed Lines %
pynapple/core/time_series.py 3 48.88%
Totals Coverage Status
Change from base Build 8651864119: -0.6%
Covered Lines: 2384
Relevant Lines: 2757

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8651925570

Details

  • 60 of 187 (32.09%) changed or added relevant lines in 11 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 84.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynapple/core/interval_set.py 1 2 50.0%
pynapple/process/correlograms.py 1 5 20.0%
pynapple/core/config.py 13 18 72.22%
pynapple/core/base_class.py 10 16 62.5%
pynapple/core/utils.py 10 25 40.0%
pynapple/core/time_series.py 5 32 15.63%
pynapple/core/core_function.py 15 84 17.86%
Files with Coverage Reduction New Missed Lines %
pynapple/core/time_series.py 3 48.88%
Totals Coverage Status
Change from base Build 8651864119: -0.6%
Covered Lines: 2384
Relevant Lines: 2757

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8651925570

Details

  • 60 of 187 (32.09%) changed or added relevant lines in 11 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 84.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynapple/core/interval_set.py 1 2 50.0%
pynapple/process/correlograms.py 1 5 20.0%
pynapple/core/config.py 13 18 72.22%
pynapple/core/base_class.py 10 16 62.5%
pynapple/core/utils.py 10 25 40.0%
pynapple/core/time_series.py 5 32 15.63%
pynapple/core/core_function.py 15 84 17.86%
Files with Coverage Reduction New Missed Lines %
pynapple/core/time_series.py 3 48.88%
Totals Coverage Status
Change from base Build 8651864119: -0.6%
Covered Lines: 2384
Relevant Lines: 2757

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8992555692

Details

  • 212 of 320 (66.25%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 83.133%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynapple/core/ts_group.py 10 12 83.33%
pynapple/core/utils.py 17 19 89.47%
pynapple/core/config.py 13 18 72.22%
pynapple/core/_core_functions.py 65 71 91.55%
pynapple/process/_process_functions.py 29 122 23.77%
Totals Coverage Status
Change from base Build 8742007044: -1.7%
Covered Lines: 2427
Relevant Lines: 2841

💛 - Coveralls

Copy link
Collaborator

@BalzaniEdoardo BalzaniEdoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments! good job, that was a ton of stuff

@@ -210,7 +205,7 @@ def test_find_support():

def test_properties():
t = np.arange(100)
d = np.random.rand(100)
d = np.random.rand(100).astype(np.float32) # to match pynajax
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might have enabled float64 in pynajax

gviejo and others added 9 commits May 7, 2024 15:27
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
@gviejo gviejo requested a review from BalzaniEdoardo May 7, 2024 21:29
Copy link
Collaborator

@BalzaniEdoardo BalzaniEdoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@gviejo gviejo merged commit a51825c into main May 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants