-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #266
Conversation
Pull Request Test Coverage Report for Build 8651925570Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 8651925570Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8651925570Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8992555692Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few comments! good job, that was a ton of stuff
@@ -210,7 +205,7 @@ def test_find_support(): | |||
|
|||
def test_properties(): | |||
t = np.arange(100) | |||
d = np.random.rand(100) | |||
d = np.random.rand(100).astype(np.float32) # to match pynajax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might have enabled float64 in pynajax
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
Co-authored-by: Edoardo Balzani <edoardo.balzani87@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
Adding
core_functions.py
to dispatch calls to numba core functions or pynajax