Fix loading and IntervalSet from NWB file with metadata #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an nwb file to ensure it is aligned correctly. also try an initial sort of an input dataframe to preserve metadata
gviejo
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with creating IntervalSets from loaded NWB files, where the IntervalSet object was being created first, thus sorting start and end times, and afterwards adding metadata that is now misaligned. This fix changes the load so that metadata is passed at creation in a dataframe with the start and end times, preserving the alignment.
An initial sort of an input dataframe start times, which preserves their relationship to each end time, is also done in an attempt to preserve the metadata. This is because when start and end times are sorted separately, as they are later in the constructor, metadata is dropped since it is unclear whether to pair metadata with the start or end time. However, if end times need to be sorted later in the constructor, metadata will still be dropped.