Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Pyodide 0.27.2 #183

Merged
merged 12 commits into from
Jan 30, 2025

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Jan 29, 2025

Description

This PR bumps the Pyodide runtime version in our CI from 0.27.0a2 to 0.27.2. Fixes a couple of failing tests.

@agriyakhetarpal agriyakhetarpal mentioned this pull request Jan 29, 2025
@agriyakhetarpal
Copy link
Member Author

I managed to fix one out of two failing tests, and the integration tests haven't proceeded to run (maybe they should be their separate job instead of a step).

I don't fully understand the failure with test_load_binary_wheel2 yet, but I can take a look at it in depth again later in the day.

@ryanking13
Copy link
Member

ryanking13 commented Jan 29, 2025

Thanks!

The failing test should use the fixture selenium_standalone_micropip, not selenium. Otherwise the micropip in the Pyodide distribution will be used (which was 0.8.0 in 0.27.2 and 0.6.0 in 0.27.0a2). I think we should find all invalid fixtures and replace it.

I don't fully understand the failure with test_load_binary_wheel2 yet, but I can take a look at it in depth again later in the day.

Looks like we are appending file:/// when no scheme is given, but it does not update the scheme in the parsed_url, so micropip fails here saying the scheme is None.

@agriyakhetarpal
Copy link
Member Author

Thanks for the pointer, @ryanking13! I fixed the tests, but I don't know if I did the change correctly.

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a comment about the scheme handling, otherwise looks good to me.

@agriyakhetarpal agriyakhetarpal added this to the 0.9.0 milestone Jan 29, 2025
@agriyakhetarpal
Copy link
Member Author

test_load_binary_wheel2 is failing consistently due to pickling errors, but I don't think it's related. I retried it a few times to see if it's not a flake, it isn't. Do you have any ideas, @hoodmane? I'll revert the change for the time being.

@agriyakhetarpal
Copy link
Member Author

I guess it was related, indeed, tests are passing now. I don't immediately see from f1de916 as to why.

@agriyakhetarpal
Copy link
Member Author

Thanks for the review! I've opened new issues so that we can track both items. I guess we should be fine to merge here, so I'll press the button.

@agriyakhetarpal agriyakhetarpal merged commit 27791c1 into pyodide:main Jan 30, 2025
8 checks passed
@agriyakhetarpal agriyakhetarpal deleted the bump/pyodide-version branch January 30, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants