-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with Pyodide 0.27.2 #183
Test with Pyodide 0.27.2 #183
Conversation
04f2541
to
c219468
Compare
I managed to fix one out of two failing tests, and the integration tests haven't proceeded to run (maybe they should be their separate job instead of a step). I don't fully understand the failure with |
Thanks! The failing test should use the fixture
Looks like we are appending |
Thanks for the pointer, @ryanking13! I fixed the tests, but I don't know if I did the change correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left a comment about the scheme handling, otherwise looks good to me.
f8d79df
to
09772c8
Compare
97c2d73
to
f1de916
Compare
|
This reverts commit f1de916.
I guess it was related, indeed, tests are passing now. I don't immediately see from f1de916 as to why. |
Thanks for the review! I've opened new issues so that we can track both items. I guess we should be fine to merge here, so I'll press the button. |
Description
This PR bumps the Pyodide runtime version in our CI from 0.27.0a2 to 0.27.2. Fixes a couple of failing tests.