fix(schema): small bug + prepare for SchemaStore #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/schemastore
branch
from
34538a9 to
f59c29e
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
Accepted: https://json.schemastore.org/cibuildwheel.json Not sure how long it takes to sync to editors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a small bug discovered when running this via SchemaStore's tests that fastjsonschema apparently doesn't care about (extra list). Also have a way to specify the full schema (with tool.cibuildwheel) so that cibuildwheel.toml/.cibuildwheel.toml can be checked. (Currently not sure how to have a subschema that doesn't have a file also, but this will at least move cibuildwheel forward, because we do).
SchemaStore/schemastore#3287