-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download cpython installer to cache dir on macos #2108
base: main
Are you sure you want to change the base?
Conversation
e8c0a11
to
040e249
Compare
040e249
to
eec7b3d
Compare
Unless the download of the installer is very slow itself, I would guess that it wouldn't change much (just moving the timings from cibuildwheel download to cache download+extract). We'd still need to install which is probably where most of the time is spent. Given all those are just guesses, seeing the actual benefits might help reason about this. Do you have runs on one of your projects showing the improvement ? EDIT: I could confirm my guesses by running with and without installer cache https://github.com/mayeut/cibuildwheel/actions/runs/12221740312/usage |
Thanks for your explanation. I agree, on GitHub CI it has roughly same speed downloading cache and python pkg, it will only benefit users with low network speed with www.python.org, and sadly I'm one of them. for example:
But cache can be really fast in internal network with local S3, using a temp cache make it uncacheable. |
I updated the PR title to make it more proper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful to a small target audience, but I don't see a downside, so why not?
Co-authored-by: Joe Rickerby <joerick@mac.com>
When download cpython on macos, download it to
CIBW_CACHE_PATH/python/
instead of temp path.So if user cache CIBW_CACHE_PATH between ci runs, they do not need to download cpython every times.
We have done similar things for pypy, but not cpython.
for example:
close #2081
travis ci failed on unrelated os