Skip to content

Make sdist.metadata_check an actual boolean #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 1 commit into from
Mar 9, 2025
Merged

Make sdist.metadata_check an actual boolean #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions distutils/command/sdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def show_formats():
class sdist(Command):
description = "create a source distribution (tarball, zip file, etc.)"

def checking_metadata(self):
def checking_metadata(self) -> bool:
"""Callable used for the check sub-command.

Placed here so user_options can view it"""
Expand Down Expand Up @@ -136,7 +136,7 @@ def initialize_options(self):
self.dist_dir = None

self.archive_files = None
self.metadata_check = 1
self.metadata_check = True
self.owner = None
self.group = None

Expand Down
2 changes: 1 addition & 1 deletion distutils/tests/test_sdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def test_metadata_check_option(self, caplog):
caplog.clear()
dist, cmd = self.get_cmd()
cmd.ensure_finalized()
cmd.metadata_check = 0
cmd.metadata_check = False
cmd.run()
assert len(self.warnings(caplog.messages, 'warning: check: ')) == 0

Expand Down
Loading