fix: remove pluggy dependency from hatchling#2217
Closed
LalatenduMohanty wants to merge 1 commit intopypa:masterfrom
Closed
fix: remove pluggy dependency from hatchling#2217LalatenduMohanty wants to merge 1 commit intopypa:masterfrom
LalatenduMohanty wants to merge 1 commit intopypa:masterfrom
Conversation
LalatenduMohanty
force-pushed
the
fix/remove-hatchling-pluggy-dependency
branch
2 times, most recently
from
2ae4f00 to
5c0b3d7
Compare
Member
|
All the doc references need to be updated including spec docs so that plugin authors know the correct way to implement plugins if this change is merged. |
Author
|
Thanks for the review! Could you clarify which specific docs you mean by "spec docs"? Are you referring to:
Want to make sure we update the right places. |
LalatenduMohanty
force-pushed
the
fix/remove-hatchling-pluggy-dependency
branch
2 times, most recently
from
57cab0b to
c3b8870
Compare
Member
|
Specifically if we are changing the mechanism the plugins about.md needs to be updated to provide information about plugin development with the new mechanism |
5 tasks
…pendency The dependency chain setuptools-scm → vcs-versioning → hatchling → pluggy → setuptools-scm creates a cycle that blocks source-only builds. Replace pluggy with a minimal stdlib-only HookRegistry using importlib.metadata for entry point discovery. Fixes pypa#752 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
fix/remove-hatchling-pluggy-dependency
branch
from
c3b8870 to
800b0d5
Compare
Author
|
@cjames23 I have updated the |
Author
|
Closing this in favor of #2076 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency chain setuptools-scm → vcs-versioning → hatchling → pluggy → setuptools-scm creates a cycle that blocks source-only builds.
Replace pluggy with a minimal stdlib-only HookRegistry using importlib.metadata for entry point discovery.
Fixes #752