Skip to content

Don't emit warning for explicitly included data files #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cdce8p wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Don't emit warning for explicitly included data files #4789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/4789.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Don't emit ``Package would be ignored`` warning for explicitly included data files.
6 changes: 5 additions & 1 deletion setuptools/command/build_py.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,10 @@ def analyze_manifest(self) -> None:
files = ei_cmd.filelist.files

check = _IncludePackageDataAbuse()
data_files = {
package: filenames
for package, _, _, filenames in self.get_data_files_without_manifest()
}
for path in self._filter_build_files(files, egg_info_dir):
d, f = os.path.split(assert_relative(path))
prev = None
Expand All @@ -208,7 +212,7 @@ def analyze_manifest(self) -> None:
continue # it's a module, not data
else:
importable = check.importable_subpackage(src_dirs[d], f)
if importable:
if importable and f not in data_files.get(d, {}):
check.warn(importable)
self.manifest_files.setdefault(src_dirs[d], []).append(path)

Expand Down
Loading