refactor: extract and narrow orm.object_session()
#17582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `object_session(...)` can return `None`, we need to help mypy have confidence that the session is indeed there. One way to narrow the type is to assert that it's not `None`, and therefore should not alert about `union-attr` problems. Includes a couple of renames, and variable extraction where relevant. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
|
Extracted from #17519 - focused only on the changes to support |
di
approved these changes
Feb 11, 2025
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
object_session(...)can returnNone, we need to help mypy have confidence that the session is indeed there.One way to narrow the type is to assert that it's not
None, and therefore should not alert aboutunion-attrproblems.Includes a couple of renames, and variable extraction where relevant.