Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency stuff #17588

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Dependency stuff #17588

merged 4 commits into from
Feb 11, 2025

Conversation

ewdurbin
Copy link
Member

  • Update bin/deps to validate that pip-compile output is what is expected for a given branch, ignoring transitive dependencies from un-merged updates
  • Add and document some make tasks that help with manually kicking off upgrades for a given project, or all projects.

@ewdurbin
do not '--upgrade' in for deps checking
cad76e0 
when un-merged releases add transitive dependencies, this check begins failing until that release is merged and the branch rebased over it.

by skipping --upgrade, we align this check to simply ensuring that the compiled .txt files match what we expect for our specified dependencies.
@ewdurbin
add/document helpers for manual dependency upgrades
6ce9ea1
@ewdurbin ewdurbin requested a review from a team as a code owner February 11, 2025 15:25
@miketheman miketheman added the developer experience Anything that improves the experience for Warehouse devs label Feb 11, 2025
miketheman
miketheman approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One nit and :shipit:

docs/dev/development/patterns.rst Outdated Show resolved Hide resolved
@miketheman
Copy link
Member

(I also just used make deps_upgrade_project P=cryptography and it worked as expected!)

ewdurbin and others added 2 commits February 11, 2025 15:13
@miketheman miketheman merged commit 310f89e into main Feb 11, 2025
20 checks passed
@miketheman miketheman deleted the dependency_stuff branch February 11, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketheman miketheman miketheman approved these changes

Assignees
No one assigned
Labels
developer experience Anything that improves the experience for Warehouse devs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewdurbin @miketheman