Skip to content

fix: AttributeError in collaborator emails when submitter is deleted #19339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobCoffee wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: AttributeError in collaborator emails when submitter is deleted #19339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
492e10b
fix(#19338): none value for submitter
JacobCoffee Jan 16, 2026
43aed1b
Merge branch 'main' into sentry-WAREHOUSE-PRODUCTION-2D6
JacobCoffee Jan 16, 2026
d505ceb
Merge branch 'main' into sentry-WAREHOUSE-PRODUCTION-2D6
JacobCoffee Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions warehouse/email/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ def send_collaborator_added_email(
return {
"username": user.username,
"project": project_name,
"submitter": submitter.username,
"submitter": submitter.username if submitter else "a deleted user",
"role": role,
}

Expand All @@ -757,7 +757,7 @@ def send_collaborator_added_email(
def send_added_as_collaborator_email(request, user, *, submitter, project_name, role):
return {
"project_name": project_name,
"initiator_username": submitter.username,
"initiator_username": submitter.username if submitter else "a deleted user",
"role": role,
}

Expand Down
Loading