feat: record new device attempts#19698
Merged
miketheman merged 2 commits intopypi:mainfrom Mar 17, 2026
Merged
Conversation
When a user authenticates with correct credentials (password + TOTP/recovery-code) from a new IP address, device_is_known() returns False, redirects to email confirmation, but records no event. The `LoginSuccess` event only fires later when the user confirms via email — and if they never confirm, there's no audit trail at all. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
JacobCoffee
reviewed
Mar 17, 2026
JacobCoffee
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user authenticates with correct credentials (password + TOTP/recovery-code) from a new IP address, device_is_known() returns False, redirects to email confirmation, but records no event.
The
LoginSuccessevent only fires later when the user confirms via email — and if they never confirm, there's no audit trail at all.