resync with upstream #49
Conversation
|
|
||
| - name: Update CMake | ||
| uses: jwlawson/actions-setup-cmake@v1.13 |
There was a problem hiding this comment.
Hmm, the PR uses lukka/get-cmake@latest, where the older one used jwlawson/actions-setup-cmake@v1.13. Are they setting different compiler flags?
There was a problem hiding this comment.
Doubtful! But actually, the older jwlawson/actions-setup-cmake@v1.13 should continue to work just fine. I think it's just that one action is slightly faster.
| run: > | ||
| cmake -S . -B build ${{ matrix.args }} | ||
| cmake -S . -B build -DNB_TEST_STABLE_ABI=ON -DNB_TEST_SHARED_BUILD="$(python3 -c 'import sys; print(int(sys.version_info.minor>=11))')" |
There was a problem hiding this comment.
Maybe these macros matter?
There was a problem hiding this comment.
The -DNB_TEST_STABLE_ABI=ON won't do anything for PyPy, this feature only becomes active on CPython >= 3.12.
The -NB_TEST_SHARED_BUILD=... allsows the extension to be split into two parts: the actual library imported into PyPy, and a shared library that contains libnanobind's support layer. But this is actually only tested on Python >= 3.11 and we are testing PyPy 3.9 and 3.10. So again, I don't think it is relevant.
Run the full nanobind matrix, xref https://github.com/orgs/pypy/discussions/4923#discussioncomment-8751961