improve, add test

pypy · Oct 25, 2019 · 71560a1 · 71560a1
1 parent 4e06dd5
commit 71560a1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/pyrepl/unix_console.py b/pyrepl/unix_console.py
@@ -356,9 +356,8 @@ def prepare(self):
         # per-readline preparations:
         try:
             self.__svtermstate = tcgetattr(self.input_fd)
-        except termios.error:  # (25, 'Inappropriate ioctl for device')
-            # assert not os.fdopen(self.input_fd).isatty()
-            raise EOFError
+        except termios.error as exc:
+            raise EOFError("could not prepare fd %d: %s" % (self.input_fd, exc))
         self._prepared = True
         raw = self.__svtermstate.copy()
         raw.iflag |= termios.ICRNL

diff --git a/testing/test_unix_console.py b/testing/test_unix_console.py
@@ -0,0 +1,12 @@
+import pytest
+
+
+def test_eoferror():
+    from pyrepl.unix_console import UnixConsole
+
+    console = UnixConsole(f_in=99)
+    with pytest.raises(EOFError) as excinfo:
+        console.prepare()
+    assert excinfo.value.args == (
+        "could not prepare fd 99: (9, 'Bad file descriptor')",
+    )