Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try importing built-in module first #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mattip
Copy link
Member

@mattip mattip commented Mar 24, 2021

The python3 relative import import ._minimal_curses will import pyrepl/_minimal_curses.py, so give a chance to the built-in _minimal_curses first

@blueyed
Copy link
Collaborator

blueyed commented Apr 11, 2021

Not sure about this in general, but test_setupterm needs adjustments (for PyPy 2/3) at least (if this is taken/done); https://travis-ci.org/github/pypy/pyrepl/jobs/764374880#L242

@@ -19,5 +19,8 @@
# CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
# CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.


from ._minimal_curses import setupterm, tigetstr, tparm, error
# First try the built-in module
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also mention that the builtin is only expected to be there with PyPy probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants