Open
Conversation
Add assert checks for checking if input vectors have the same length. This will help the rust compiler later to elide bound checks.
Use zipped iterators instead of indexing to elide bound checks.
Collaborator
|
Do you have benchmarks that show that this is faster? Just curious |
Author
|
No, I don't have a benchmark that shows a real difference, but I assume the difference will be hardly noticeable as currently sorting input/output will probably dominate most of the running time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite all functions in sorts.rs to use zipped iterators to iterate over multiple vectors, instead of using indexing operations to get the values.
When using indexing operations into vectors, the rust compiler will do bound checks to see if it is not indexing past the end of the vector.
By first check that all input vectors have the same length, and by using zipped iterators over the vectors the rust compiler can elide all those bound checks and should be able to generate faster code.