adding shutting_down parameter to update() to signal when is the last… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call. this allows the update to do some cleanup.
|
@dhirajdhule What do you think about this ? We also need to check with #10 I start to need more control over zmp node shutdown behavior, for pyros to properly cleanup it s environment, so I made this very quick commit, but I didn't have time to think much about overall design yet... Let me know if you have any comment about it, thanks ! |
|
ON HOLD... Not sure this is actually needed. Need to investigate the startup/shutdown behavior in rostful + pyros + pyzmp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… call. this allows the update to do some cleanup.