Skip to content

fix: Fix Mac OS downloading #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 16, 2025
Merged

fix: Fix Mac OS downloading #1517

merged 9 commits into from
May 16, 2025

Conversation

Lockl00p
Copy link
Contributor

@Lockl00p Lockl00p commented May 7, 2025

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

A simple fix to make asynch-dns = false only apply to iOS

The items not marked don’t work on iOS (likely due to how you can only launch VLC with the link and nothing more)

also, this wasn’t tested on Mac OS as I do not have a Mac. It should work tho

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • [C] -e (select episode) aka -r (range selection) works
  • -S select index works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --exit-after-play auto exit after playing works
  • --nextep-countdown countdown to next ep works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)
  • All Providers: Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu e (TV) (3 m3u8, 3 mp4, 1 fast4speed, 1 sharepoint)
  • The examples of the help text

@Lockl00p Lockl00p requested a review from Derisis13 as a code owner May 7, 2025 20:18
@Lockl00p Lockl00p changed the title Fix: Fix Mac OS downloading fix: Fix Mac OS downloading May 7, 2025
@71zenith 71zenith self-requested a review May 9, 2025 14:02
Copy link
Collaborator

@71zenith 71zenith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a different naming case would have been nice

@ryuuskylark
Copy link

Hi there, I created the issue related to this PR.

I have tested it on:
Macbook Pro (Apple M3 Pro)
macOS: Sequoia 15.4.1

As far as testing my use case and some various of the above use cases worked as well.
I seem to have had an issue with it connecting to vlc worked perfectly for my use cases.

Thanks @Lockl00p

@Lockl00p
Copy link
Contributor Author

As far as testing my use case and some various of the above use cases worked as well. I seem to have had an issue with it connecting to vlc worked perfectly for my use cases.

@ryuuskylark
Wait so does it not work with iina?

@ryuuskylark
Copy link

ryuuskylark commented May 11, 2025 via email

@Lockl00p
Copy link
Contributor Author

Thanks for the clarification, mate!

Copy link

@Adajone Adajone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to reproduce #1513 with this fix 👍

@ihor-povrozniuk
Copy link

I left a comment in #1513
This version solves the problem for me

@port19x port19x merged commit c5877c5 into pystardust:master May 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants