Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate HNHN implementation #150

Merged
merged 11 commits into from
Aug 24, 2023
Merged

Merge duplicate HNHN implementation #150

merged 11 commits into from
Aug 24, 2023

Conversation

ninamiolane
Copy link
Collaborator

This PR follows from PR #127 and merge the code with the duplicate implementation of HNHN

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ninamiolane ninamiolane changed the title Merge duplicated HNHN implementation Merge duplicate HNHN implementation Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #150 (b41cf01) into main (f862ec0) will decrease coverage by 0.04%.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   97.45%   97.42%   -0.04%     
==========================================
  Files          24       25       +1     
  Lines         905      969      +64     
==========================================
+ Hits          882      944      +62     
- Misses         23       25       +2     
Files Changed Coverage Δ
topomodelx/nn/hypergraph/hnhn_layer.py 96.87% <96.66%> (-3.13%) ⬇️
topomodelx/nn/hypergraph/hnhn_layer_bis.py 100.00% <100.00%> (ø)

@ninamiolane ninamiolane merged commit 922f771 into main Aug 24, 2023
9 of 10 checks passed
@ninamiolane ninamiolane deleted the hnhn branch August 24, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants