Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate Scone Implementation #151

Merged
merged 12 commits into from
Aug 24, 2023
Merged

Merge duplicate Scone Implementation #151

merged 12 commits into from
Aug 24, 2023

Conversation

ninamiolane
Copy link
Collaborator

This PR follows PR #119 and merge it with duplicate implementation of Scone.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #151 (1018c4b) into main (f862ec0) will increase coverage by 0.02%.
Report is 71 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   97.45%   97.47%   +0.02%     
==========================================
  Files          24       26       +2     
  Lines         905      992      +87     
==========================================
+ Hits          882      967      +85     
- Misses         23       25       +2     
Files Changed Coverage Δ
topomodelx/base/aggregation.py 100.00% <100.00%> (ø)
topomodelx/nn/simplicial/scone_layer.py 100.00% <100.00%> (ø)
topomodelx/nn/simplicial/scone_layer_bis.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ninamiolane ninamiolane merged commit 7b7738c into main Aug 24, 2023
6 checks passed
@levtelyatnikov levtelyatnikov deleted the scone branch October 18, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants