-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #169, Thumbnails Updated #183
Conversation
@devendragovil Thanks!! And thanks for being that fast. For some of them, the cropping is not very clean: parts of the neighboring tensor diagrams appear. I will send you the .svg version of the figure via email, so that you can crop only the diagram for each thumbnail. Then we can merge! |
@ninamiolane Having SVG files would be awesome for quality and clarity. Reproducing the previous comment below: I have updated the thumbnails with tensor diagrams, I came across the following issues though:
|
@ninamiolane , it might be a good idea to give @devendragovil the original CSV file to extract the TD from the file immediately. |
@devendragovil I've answered on the issue + shared the editable Fig 11 via email. |
@devendragovil converting to draft for now. Let me know when it's ready? Side note: can_bis and scone_bis do not exist anymore. You can remove anything related to them. Thanks! |
To make sure stuff works with updated changes
…editable file; Improving structure of Tutorials Page and Tutorials display; Adding README for tutorial contributors
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The latest changes help resolve #169 and #162. @ninamiolane Requesting your review. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 57 57
Lines 2070 2070
=======================================
Hits 2014 2014
Misses 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!! Thank you so much.
Updated the thumbnails with tensor diagrams as suggested in #169