Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypergraph: Add equations in docstrings of forward methods #194

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Hypergraph: Add equations in docstrings of forward methods #194

merged 2 commits into from
Sep 8, 2023

Conversation

gurug-dev
Copy link
Contributor

Changes addressing #168.

Notes:

  • template_layer doesn't have corresponding eqns in awesome-tnn docs, I'm assuming as the name suggests, the code contains a basic template example. Skipped that.
  • hnhn_layer_bis seems to be about HNHN, but a secondary class, HNHN already had updated forward docstrings, unsure what is to be done here.

ninamiolane
ninamiolane approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

You're right: no equations for template_layer.

HNHN bis is a separate problem, that someone else will deal with in another PR. Good to leave it like that.

@ninamiolane
Copy link
Collaborator

@gurug-dev there is a lint issue. Could you run black on the repo and re-commit?
Thanks. black .

@gurug-dev
Copy link
Contributor Author

gurug-dev commented Sep 8, 2023 •
edited
Loading

@ninamiolane done, lint error was due to some other unrelated code, fixed now. Thank you!

@gurug-dev gurug-dev mentioned this pull request Sep 8, 2023
Open
@ninamiolane
Copy link
Collaborator

Ah, right, it was from the SAN model. Thanks!

@ninamiolane ninamiolane merged commit 5814e1c into pyt-team:main Sep 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane ninamiolane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurug-dev @ninamiolane