Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate more ruff rules #270

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Activate more ruff rules #270

merged 9 commits into from
Mar 4, 2024

Conversation

ffl096
Copy link
Member

@ffl096 ffl096 commented Feb 21, 2024

@ffl096 ffl096 self-assigned this Feb 21, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

# Conflicts:
#	topomodelx/nn/cell/can.py
#	topomodelx/nn/cell/ccxn.py
#	topomodelx/nn/simplicial/san.py
#	tutorials/cell/ccxn_train.ipynb
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a158cbf) 97.40% compared to head (c25eef5) 97.07%.

Files Patch % Lines
topomodelx/utils/scatter.py 66.66% 2 Missing ⚠️
topomodelx/base/aggregation.py 0.00% 1 Missing ⚠️
topomodelx/nn/hypergraph/hypergat_layer.py 0.00% 1 Missing ⚠️
topomodelx/nn/simplicial/sccnn_layer.py 0.00% 1 Missing ⚠️
topomodelx/nn/simplicial/scnn_layer.py 50.00% 1 Missing ⚠️
topomodelx/nn/simplicial/scone.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   97.40%   97.07%   -0.34%     
==========================================
  Files          58       58              
  Lines        2084     2014      -70     
==========================================
- Hits         2030     1955      -75     
- Misses         54       59       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffl096 ffl096 merged commit 3812fc5 into main Mar 4, 2024
22 of 24 checks passed
@ffl096 ffl096 deleted the frantzen-ruff-2 branch March 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant