Disable assertion rewriting external modules

[Tusenka]

Disable assertion rewriting of external modules. Closes 13403.

[Tusenka]

Need to squash commits - OK to close, I'll reopen a new one with one commit

[RonnyPfannschmidt]

thank you for getting this started

i believe we need to put the path handling into assertion state so it can correctly pass from the configuration and include the invocation dir/rootdir in a more safe manner than the current heusterics

[nicoddemus]

I skimmed through the issue (I'm short on time so I cannot do a more through research), but looking at the code is not immediately clear to me so thought I would ask:

Note that we want to rewrite asserts for files belonging to a pytest plugin, even if they are not test_*.py files. How does this patch relate to that? This is an important behavior that should be kept.

[Tusenka]

I skimmed through the issue (I'm short on time so I cannot do a more through research), but looking at the code is not immediately clear to me so thought I would ask:

Note that we want to rewrite asserts for files belonging to a pytest plugin, even if they are not test_*.py files. How does this patch relate to that? This is an important behavior that should be kept.

At present time the fix is applied only for path which applies test_*py. The plugins are processed separately. I'll add some tests against that important part.

[Tusenka]

I skimmed through the issue (I'm short on time so I cannot do a more through research), but looking at the code is not immediately clear to me so thought I would ask:
Note that we want to rewrite asserts for files belonging to a pytest plugin, even if they are not test_*.py files. How does this patch relate to that? This is an important behavior that should be kept.

At present time the fix is applied only for path which applies test_*py. The plugins are processed separately. I'll add some tests against that important part.

Added some tests for plugin rewriting, it works now

[nicoddemus]

Thanks @Tusenka,

Left some comments, please take a look.

[nicoddemus]

My previous suggestion about using a real-case scenario makes this test unnecessary.

[Tusenka]

I see the code coverage in that case is less than 100%

[Tusenka]

Do we need to rewrite contest plugins? It's the not original behavior

[RonnyPfannschmidt]

Conftest files that are part of the collection should rewrite as far as I remember

[RonnyPfannschmidt]

my understanding is that rewrite of conftest plugins was always happening as part of the original assertion hooking

[Tusenka]

But it still doen't see conftest plugins

Result of provided plugins:
['pytest', 'zope.interface', 'idna', 'anyio', 'sniffio', 'filelock', 'cachetools', 'incremental', 'greenlet', 'pluggy', 'hypothesis', 'Automat', 'wheel', 'virtualenv', 'coverage', 'pip', 'distlib', 'mock', 'pre_commit', 'typing_extensions', 'elementpath', 'pytest-twisted', 'PyYAML', 'pyproject-api', 'identify', 'colorama', 'urllib3', 'hyperlink', 'Pygments', 'sortedcontainers', 'constantly', 'nodeenv', 'xmlschema', 'setuptools', 'attrs', 'requests', 'pytest', 'exceptiongroup', 'decorator', 'platformdirs', 'packaging', 'charset-normalizer', 'cfgv', 'Twisted', 'certifi', 'chardet', 'tox', 'argcomplete', 'iniconfig', 'jaraco.collections', 'zipp', 'typeguard', 'wheel', 'importlib_metadata', 'jaraco.text', 'jaraco.context', 'autocommand', 'tomli', 'typing_extensions', 'more-itertools', 'jaraco.functools', 'packaging', 'platformdirs', 'inflect', 'backports.tarfile']

The conftest plugins are loaded after the PEP302/PEP451 import hook considers files to rewrite.
I propose a separate ticket for conftest plugins rewritng.
I'll try to "play" with this.

[Tusenka]

I see code coverage is less than 100%(96%), maybe add some unit tests?
Also mypy doesn't like the packeage name, created a question on stackoverflow
nicoddemus[RonnyPfannschmidt], what do you think?

[nicoddemus]

@Tusenka

testing/example_scripts/rewrite/src/main.py: error: Source file found twice under different module names: "example_scripts.rewrite.src.main" and "testing.example_scripts.rewrite.src.main"
testing/example_scripts/rewrite/src/main.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
testing/example_scripts/rewrite/src/main.py: note: Common resolutions include: a) adding `__init__.py` somewhere, b) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)

I would scratch the explicit files in testing/example_scripts and create the scripts inside the tests that use them, with pytester. This side steps the issue entirely.

[Tusenka]

@Tusenka

testing/example_scripts/rewrite/src/main.py: error: Source file found twice under different module names: "example_scripts.rewrite.src.main" and "testing.example_scripts.rewrite.src.main"
testing/example_scripts/rewrite/src/main.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
testing/example_scripts/rewrite/src/main.py: note: Common resolutions include: a) adding `__init__.py` somewhere, b) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)

I would scratch the explicit files in testing/example_scripts and create the scripts inside the tests that use them, with pytester. This side steps the issue entirely.

Thank you a lot. I would try to invoke the script in the acceptance tests.

[Tusenka]

Stuck on relative import - digging in