Fix skip bug in which if exception group has all skips it reported error instead of skip

[gomri15]

Added handling for exception group with only skips inside of it to the reporter

fixes issue: #13537

[nicoddemus]

This PR also contains the commits from #13757, could you fix this please? Thanks!

[gomri15]

This PR also contains the commits from #13757, could you fix this please? Thanks!

Done.
Thank you so much for the review, i can only imagine how busy you are with all these reviews.

[bluetech]

Didn't think too much about this, just some comments from reading the PR.

[gomri15]

@bluetech Thanks for the review I fixed all the comments

Summary of changes:

• Change test to be more readable by using parametrization with better names and more explicit parameters
• Casting to Sequence[BaseExceptions] instead Sequence[Skip] which was wrong
• Removed redundant comments and changed some comments to ready like sentences

Note: checking if exceptions exist and its insides feels a bit hacky to me using getattr and literal check if excinfo.value.exceptions but I couldn't find a better way of doing this.

open to suggestions, wasn't sure how much more energy should be spent on this since it's such a edge case scenario.

i remember @bluetech mentioned flattening the exception group in #13650 maybe that is the way to go for better clarity and not having to explicitly check the insides of excinfo.value so literally

also so saw a suggestion for TypeGuard but because haven't seen this logic before i the project i hesitated to add it just for this use case

[gomri15]

@Zac-HD could you have another look see if something else needs doing ?

[Zac-HD]

Looks good - thanks again for the contribution @gomri15, and for your patience!

stale