doc: add "Use pytest's strict mode" to good practices#13852
Merged
bluetech merged 1 commit intopytest-dev:mainfrom Oct 28, 2025
Merged
doc: add "Use pytest's strict mode" to good practices#13852bluetech merged 1 commit intopytest-dev:mainfrom
bluetech merged 1 commit intopytest-dev:mainfrom
Conversation
Member
The-Compiler
left a comment
The-Compiler
left a comment
There was a problem hiding this comment.
Yay, looks great overall!
doc/en/explanation/goodpractices.rst
Outdated
| See the :confval:`strict` for the options it enables and their effect. | ||
|
|
||
| If pytest adds new strictness options in the future, they will also be enabled by ``strict``. | ||
| Therefore, you should only use ``strict`` if you use a locked version of pytest, |
Member
There was a problem hiding this comment.
Suggested change
| Therefore, you should only use ``strict`` if you use a locked version of pytest, | |
| Therefore, you should only use ``strict`` if you use a pinned version of pytest, |
maybe?
Member
Author
There was a problem hiding this comment.
I think both terms are used, so I went with "pinned/locked".
| .. _`strict mode`: | ||
|
|
||
| Using pytest's strict mode | ||
| -------------------------- |
Member
There was a problem hiding this comment.
Should this maybe have a versionadded directive, and/or a quick blurb on how to achieve the same result with older pytest versions?
Member
Author
There was a problem hiding this comment.
Added the versionadded. I didn't add how to achieve in previous versions, hopefully can be understood by following the links.
bluetech
force-pushed
the
strict-good-practice
branch
from
b263229 to
d68eba9
Compare
Member
Author
|
Thanks for the reviews. I also sync'd the text in the reference/changelog/goodpractice. |
nicoddemus
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe it can increase adoption.