Merged
Conversation
No reason for it that I can see.
Whatever pip is used almost certainly has the new resolver by now.
This way CI doesn't need to install coverage on its own just to run the `coverage report xml` command, instead it goes through tox.
I don't think it's needed.
No need to upgrade when it's not already installed.
This way it can only affect pytest. Don't think it matters here but only for consistency.
bluetech
force-pushed
the
tox-tweaks-2
branch
from
11952d6 to
665363a
Compare
nicoddemus
approved these changes
Nov 12, 2025
webknjaz
reviewed
Nov 12, 2025
Comment on lines
57
to
+58
| python -m pip install --upgrade pip | ||
| pip install --upgrade tox | ||
| pip install tox |
Member
There was a problem hiding this comment.
Personally, I'd skip pip and have the entire env with tox pinned via --constraint=.
Member
Author
There was a problem hiding this comment.
I'm not familiar with this, how to skip pip but still get tox installed?
Member
There was a problem hiding this comment.
I meant skip the previous line and have constraint on this one.
Member
There was a problem hiding this comment.
Although, technically pipx is pre-installed so this could be skipped if there's no desire to pin the env.
webknjaz
reviewed
Nov 12, 2025
| @@ -174,9 +175,6 @@ description = | |||
| run reverse dependency testing against pytest plugins under `{basepython}` | |||
| # use latest versions of all plugins, including pre-releases | |||
| pip_pre=true | |||
Member
Author
There was a problem hiding this comment.
It's intentional per the comment above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.