feat: add --report-chars long option and its corresponding test#14024
feat: add --report-chars long option and its corresponding test#14024jakkdl merged 10 commits intopytest-dev:mainfrom
Conversation
for more information, see https://pre-commit.ci
…g forms with various values.
|
Hi @jakkdl , I tried parameterizing the test case as instructed. Do you mind taking a look again? |
|
rewrote the parametrize to be slightly cleaner :) Looking at vs but I don't think it really matters. I'll merge this in a few days unless somebody pops in and notices something, thank you! |
|
Thanks @junhaoliao for the PR and @jakkdl for merging! @jakkdl just a note, in the future prefer to squash the commits when they by themselves are not very valuable to keep in the history (for example, "add changelog", "precommit fixes", etc). Thanks again folks! |
|
frick sorry, not the first time it happened. I used to have a monkeyscript that warned about it but it appears to have gotten disabled at some point. |
|
No worries! |
closes #14023
This change introduces a long-form CLI option
--report-charsas an alternative to the existingshort
-roption.Here is a quick checklist that should be present in PRs.
If this change fixes an issue, please:
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Create a new changelog file in the
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Also make sure to end the sentence with a
..Add yourself to
AUTHORSin alphabetical order.