don't crash if exceptiongroup has only hidden tb frames#14025
Merged
jakkdl merged 5 commits intopytest-dev:mainfrom Dec 12, 2025
Merged
don't crash if exceptiongroup has only hidden tb frames#14025jakkdl merged 5 commits intopytest-dev:mainfrom
jakkdl merged 5 commits intopytest-dev:mainfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
approved these changes
Dec 2, 2025
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
LGTM, short of one cosmetic improvement request.
Member
Author
|
I played around a bit with the test and noticed that "tbstyle=line" now outputs "All traceback entries are hidden", and "ValueError: bar" will match in all cases. So I removed/updated the relevant if statements. |
nicoddemus
added
the
backport 9.0.x
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: Backported as #14045 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 14, 2025
* don't crash if exceptiongroup has only hidden tb frames (cherry picked from commit fa6a232)
nicoddemus
pushed a commit
that referenced
this pull request
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13734
yet another bandaid that would've been avoided if we had full support for exception groups in
ExceptionInfo& friends 😶 see #9159