Improve assertion message for pytest.__all__ test#14075
Closed
RaghavSinghal15 wants to merge 5 commits intopytest-dev:mainfrom
Closed
Improve assertion message for pytest.__all__ test#14075RaghavSinghal15 wants to merge 5 commits intopytest-dev:mainfrom
RaghavSinghal15 wants to merge 5 commits intopytest-dev:mainfrom
Conversation
Author
|
This PR only affects tests and internal assertions. |
Pierre-Sassoulas
added
the
bot:chronographer:provided
Member
|
Thanks, but why do you think this is necessary? pytest after all provides assertion rewriting, and I get this output if I edit one of the parameters to an invalid name ( This feels clear enough to me, IMHO. |
Author
|
Yeah, that’s fair. the rewritten assertion already makes it pretty clear. I’m fine dropping this if you don’t think it’s worth keeping. |
Member
|
I agree. Thanks anyway for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the assertion message in the pytest.all namespace test.
The change does not alter behavior, but provides a clearer error message if an expected public attribute is missing from pytest.all, making debugging easier.