typing: default for xfail condition is True#14106
Merged
bluetech merged 1 commit intopytest-dev:mainfrom Jan 12, 2026
Merged
Conversation
TrueTrue
TrueTrue
bluetech
approved these changes
Jan 12, 2026
Member
bluetech
left a comment
There was a problem hiding this comment.
Thanks!
I considered asking to change to = ... but I remembered that typeshed changed its policy about this and now includes default values (useful for IDEs and such), so let's follow that.
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: Backported as #14107 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
typing: default for xfail condition is `True` (cherry picked from commit 317ea9a)
bluetech
added a commit
that referenced
this pull request
Jan 12, 2026
…17ea9a7c887cccede7e42bc6d82533d3be68c26/pr-14106 [PR #14106/317ea9a7 backport][9.0.x] typing: default for xfail condition is `True`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has absolutely no runtime impact (hence no changelog entry), but it makes reading the code less confusing.