Skip to content

Comments

typing: default for xfail condition is True#14106

Merged
bluetech merged 1 commit intopytest-dev:mainfrom
flying-sheep:xfail-default
Jan 12, 2026
Merged

typing: default for xfail condition is True#14106
bluetech merged 1 commit intopytest-dev:mainfrom
flying-sheep:xfail-default

Conversation

@flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Jan 12, 2026

This has absolutely no runtime impact (hence no changelog entry), but it makes reading the code less confusing.

@flying-sheep flying-sheep changed the title fix: default for xfail condition is True typing: make default for xfail condition is True Jan 12, 2026
@flying-sheep flying-sheep changed the title typing: make default for xfail condition is True typing: default for xfail condition is True Jan 12, 2026
@bluetech bluetech added skip news used on prs to opt out of the changelog requirement backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch labels Jan 12, 2026
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I considered asking to change to = ... but I remembered that typeshed changed its policy about this and now includes default values (useful for IDEs and such), so let's follow that.

@bluetech bluetech merged commit 317ea9a into pytest-dev:main Jan 12, 2026
33 checks passed
@patchback
Copy link

patchback bot commented Jan 12, 2026

Backport to 9.0.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/9.0.x/317ea9a7c887cccede7e42bc6d82533d3be68c26/pr-14106

Backported as #14107

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 12, 2026
typing: default for xfail condition is `True`
(cherry picked from commit 317ea9a)
bluetech added a commit that referenced this pull request Jan 12, 2026
…17ea9a7c887cccede7e42bc6d82533d3be68c26/pr-14106

[PR #14106/317ea9a7 backport][9.0.x] typing: default for xfail condition is `True`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch skip news used on prs to opt out of the changelog requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants