raises: fix stale loop variable in RaisesGroup error reporting#14220
Open
bysiber wants to merge 3 commits intopytest-dev:mainfrom
Open
raises: fix stale loop variable in RaisesGroup error reporting#14220bysiber wants to merge 3 commits intopytest-dev:mainfrom
bysiber wants to merge 3 commits intopytest-dev:mainfrom
Conversation
In _check_exceptions, the diagnostic loop at line 1368 uses i_exp (last value from the earlier enumerate loop) instead of i_failed (the current loop variable). This causes incorrect result lookups when building the failure message for unmatched expected exceptions.
Member
|
Thanks! Could you please add a regression test to catch this issue? |
Tests that the error message for failed expected exceptions uses the correct index (i_failed) rather than a stale i_exp from a prior loop.
for more information, see https://pre-commit.ci
Author
|
Added a regression test that exercises the error message path with multiple expected exceptions where a non-last expected fails. The test verifies the correct exception types appear in the failure output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
RaisesGroup._check_exceptions, the diagnostic section that builds failure messages for unmatched expected exceptions has a bug on this line:i_exphere is a leftover from the earlierfor i_exp, expected in enumerate(self.expected_exceptions):loop that computes the full results matrix. By the time we reach this diagnostic loop,i_expholds whatever value it had when that earlier loop finished -- it doesn't track the currenti_failediteration at all.This means the
results.get_result(i_exp, i_actual)call looks up the wrong expected exception's result, so the "It matches ... which was paired with ..." hints in the failure output can be completely wrong or missing.Fix: replace
i_expwithi_failed, which is the actual loop variable for the current expected exception being reported.