Контрольная работа №1#12
Open
MenshikovaElizaveta wants to merge 8 commits intopython-course-matmex:mainfrom
Open
Контрольная работа №1#12MenshikovaElizaveta wants to merge 8 commits intopython-course-matmex:mainfrom
MenshikovaElizaveta wants to merge 8 commits intopython-course-matmex:mainfrom
Conversation
Godrik0
reviewed
Dec 13, 2025
Godrik0
left a comment
Godrik0
left a comment
There was a problem hiding this comment.
ISBN10: 0/10
Бинарный поиск: 2/5
Оформление: 7/10 (необходимо было использовать snake_case в названиях)
Comment on lines
+2
to
+5
| if x not in xs: | ||
| raise ValueError("такого элемента нет") | ||
| if xs != sorted(xs): | ||
| raise ValueError("Массив не отсортирован") |
There was a problem hiding this comment.
Эти проверки полностью лишают смысла весь алгоритм. Поиск в xs имеет сложность
Можно было проверять, что x имеет тип int.
Comment on lines
+17
to
+24
| def test_unsorted(): | ||
| with pytest.raises(ValueError, match="Массив не отсортирован"): | ||
| binSearch([8, 3, 6, 1], 6) | ||
|
|
||
|
|
||
| def test_unsorted(): | ||
| with pytest.raises(ValueError, match="такого элемента нет"): | ||
| binSearch([1, 2, 3], 9) |
There was a problem hiding this comment.
Тесты имеют одинаковое название, вторая функция перезапишет первую.
Comment on lines
13
to
14
| def test_not_in_list(): | ||
| assert binSearch([1, 2, 3, 4], 5) == -1 |
There was a problem hiding this comment.
В текущей реализации метода, этот тест неверен. У вас бросается ошибка если элемента нет, а тут ожидается -1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Меньшикова Елизавета Фёдоровна Б42
Добавлены файлы .gitignore и LICENSE.
В файле tests.yml исправлена версия Python.
Исправлен код для поиска номера числа в массиве.
Добавлены исключения в соответствующих случаях и тесты к ним.
В тесты добавлены инструкции импорта для использования фреймворка pytest.