Решение контрольной работы. Семенский Роман Николаевич Б-42#13
Open
rmnsmnsk wants to merge 16 commits intopython-course-matmex:mainfrom
Open
Решение контрольной работы. Семенский Роман Николаевич Б-42#13rmnsmnsk wants to merge 16 commits intopython-course-matmex:mainfrom
rmnsmnsk wants to merge 16 commits intopython-course-matmex:mainfrom
Conversation
Добавляю лицензию
Добавляю gitignore
rmnsmnsk
changed the title
added 3 commits
November 7, 2025 17:51
Godrik0
reviewed
Dec 13, 2025
Godrik0
left a comment
Godrik0
left a comment
There was a problem hiding this comment.
ISBN10: 7/10
Бинарный поиск: 2/5
Оформление: 7/10 (__pycahe__ в PR)
Comment on lines
+9
to
+14
| for i in xs: | ||
| if not isinstance(i, int): | ||
| return -1 | ||
|
|
||
| if xs != sorted(xs): | ||
| return -1 |
There was a problem hiding this comment.
Эти проверки полностью лишают смысла весь алгоритм. Поиск в xs имеет сложность
Comment on lines
+6
to
+9
| digits = [int(char) for char in isbn_number if char.isdigit()] | ||
|
|
||
| if len(digits) != 10: | ||
| return False |
There was a problem hiding this comment.
У Вас пропущена обработка символа X, который может служить контрольной цифрой.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Задачи:
bin_search:
Было неверно написано, что while left < right - не находил элементы на границах массива (первый и последний)
Исправил на while left <= right - теперь находит все элементы включая граничные
checksum:
Не изменялся вес цифры
В качестве исключений были добавлены:
Остальное:
Также были был добавлены .gitignore и LICENSE, дополнен readme