Кузьмищев Леонид Сергеевич 25Б-42#15
Draft
leonilkuz-13 wants to merge 9 commits intopython-course-matmex:mainfrom
Draft
Кузьмищев Леонид Сергеевич 25Б-42#15leonilkuz-13 wants to merge 9 commits intopython-course-matmex:mainfrom
leonilkuz-13 wants to merge 9 commits intopython-course-matmex:mainfrom
Conversation
Author
|
/request-review @chernishev |
Godrik0
reviewed
Dec 13, 2025
Godrik0
left a comment
Godrik0
left a comment
There was a problem hiding this comment.
ISBN10: 7/10
Бинарный поиск: 5/5
Оформление: 8/10 (нет лицензии, .gitignore)
Comment on lines
+27
to
+39
| print("Exit - -1") | ||
| print("To enter, enter any number") | ||
| string = input() | ||
| while True: | ||
| print("enter ISBN_number or came out") | ||
| if string == "-1": | ||
| print("you came out") | ||
| break | ||
| string = input() | ||
| if modulo11_checksum(string): | ||
| print("correct") | ||
| else: | ||
| print("incorrect") |
There was a problem hiding this comment.
Когда pytest импортирует этот файл для тестов, он зависнет, ожидая ввода данных.
Код, который относится к запуску нужно оборачивать в if __name__ == "__main__".
Comment on lines
+14
to
+15
| if digits is None: | ||
| return False |
There was a problem hiding this comment.
Рекомендация: при неверной длине строки (или других ошибках) лучше выбрасывать исключение, чтобы различать некорректный формат входных данных и просто невалидную контрольную сумму.
Тогда в вызывающем коде нужно будет добавить блок try-except.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checksum was fixed, errors in binary search were added. Tests were written for 2 files. A README was added. A console utility was written for checksum