Тупикова Екатерина Викторовна, Б42#16
Open
sugahu565 wants to merge 16 commits intopython-course-matmex:mainfrom
Open
Тупикова Екатерина Викторовна, Б42#16sugahu565 wants to merge 16 commits intopython-course-matmex:mainfrom
sugahu565 wants to merge 16 commits intopython-course-matmex:mainfrom
Conversation
Godrik0
reviewed
Dec 13, 2025
Godrik0
left a comment
Godrik0
left a comment
There was a problem hiding this comment.
ISBN10: 8/10
Бинарный поиск: 4/5
Оформление: 8/10 (snake_case, .gitignore)
| def bin_search(xs: list[int], x: int): | ||
|
|
||
| if type(x) != int: | ||
| raise "x is not int" |
There was a problem hiding this comment.
В Python 3.x мы уже не можем кидать строки как исключения.
| digits = [int(char) for char in ISBNNumber if char.isdigit()] | ||
|
|
||
| checkDigit = digits[-1] | ||
| assert (len(digits) == 9 and ISBNNumber[-1] == "X") or len(digits) == 10, "invalid lenght" |
There was a problem hiding this comment.
Валидация на assert это плохо, он предназначен для отладки, и при запуске с флагом -O все ассерты вырезаются.
| @@ -1,14 +1,38 @@ | |||
| def modulo11Checksum(ISBNNumber: str): | |||
There was a problem hiding this comment.
Почему-то тут не поменяли на snake_case.
|
|
||
| left, right = 0, len(xs) - 1 | ||
| while left < right: | ||
| while left <= right: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.