Васильев Михаил Владимирович, 25.Б42-мм#18
Open
MichaelVasiliev24 wants to merge 11 commits intopython-course-matmex:mainfrom
Open
Васильев Михаил Владимирович, 25.Б42-мм#18MichaelVasiliev24 wants to merge 11 commits intopython-course-matmex:mainfrom
MichaelVasiliev24 wants to merge 11 commits intopython-course-matmex:mainfrom
Conversation
Godrik0
suggested changes
Dec 13, 2025
Godrik0
left a comment
Godrik0
left a comment
There was a problem hiding this comment.
ISBN10: 6/10
Бинарный поиск: 0/5
Оформление: 10/10
There was a problem hiding this comment.
В задании требовалось также реализовать консольную утилиту.
Comment on lines
+5
to
+11
| raise Exception( | ||
| "Количество значащих символов, то есть не считая пробелов и тире, в ISBN номере должно равняться 10." | ||
| ) | ||
| if not digits_str[:9].isdigit() or digits_str[9] not in "0123456789Xx": | ||
| raise Exception( | ||
| "ISBN может содержать только арабские цифры, а также римскую цифру X для контрольной цифры." | ||
| ) |
There was a problem hiding this comment.
Использовать Exception -- плохая практика, следовало указать конкретный тип ошибки, например ValueError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing files (gitignore, requiremetns, license), changed README and corrected CI configuration files, fixed bugs in checksum, expanded tests for it.