Open
Conversation
Godrik0
reviewed
Dec 13, 2025
Godrik0
left a comment
Godrik0
left a comment
There was a problem hiding this comment.
ISBN10: 6/10
Бинарный поиск: 5/5
Оформление: 9/10 (нет описания PR)
Comment on lines
+24
to
+35
| while True: | ||
| user_input = input("Enter an ISBN10 number or '-1' to exit: ") | ||
|
|
||
| if user_input == "-1": break | ||
|
|
||
| try: | ||
| if modulo11_checksum(user_input): | ||
| print("correct") | ||
| else: | ||
| print("incorrect") | ||
| except Exception as ex: | ||
| print(f"An error occurred: {ex}") No newline at end of file |
There was a problem hiding this comment.
Когда pytest импортирует этот файл для тестов, он зависнет, ожидая ввода данных.
Код, который относится к запуску нужно оборачивать в if __name__ == "__main__".
Comment on lines
+2
to
+5
| digits = '' | ||
| for char in isbn_number: | ||
| if char.isdigit(): | ||
| digits += char |
There was a problem hiding this comment.
У Вас пропущена обработка символа X, который может служить контрольной цифрой.
Comment on lines
+12
to
+25
| def test_short_string(): | ||
| assert not modulo11_checksum("2-266-6-3") | ||
|
|
||
|
|
||
| def test_long_string(): | ||
| assert not modulo11_checksum("2-266-21132312332316-3") | ||
|
|
||
|
|
||
| def test_empty_string(): | ||
| assert not modulo11_checksum("") | ||
|
|
||
|
|
||
| def test_none_input(): | ||
| assert not modulo11_checksum(None) No newline at end of file |
There was a problem hiding this comment.
if len(digits) != 10:
raise ValueError('ISBN must have exactly 10 characters')В тестах у вас ожидается False, а произойдет ошибка, тесты упадут.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.