Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all accepted mail domains to SRS exclude configuration #528

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Sep 1, 2024

We don't want to rewrite the envelopes of mail that is from a valid
domain of our mailserver (e.g. pydis.com or int.pydis.wtf), but by
default PostSRSD will rewrite anything that is not the mydomain
configuration variable of Postfix (which is just set to pydis.wtf for
us).

This change updates the environment defaults for PostSRSD to ensure that
we don't change any envelopes that don't need to be changed, as well as
ensuring that to end mailservers the DKIM and SPF checks are made
against the actual domain (e.g. int.pydis.wtf) instead of the rewritten
envelope.

@github-actions github-actions bot added group: ansible Issues and pull requests related to the Ansible setup component: email Issues relating to our email forwarding system, hosted on our netcup machines. labels Sep 1, 2024
@jchristgit jchristgit self-requested a review September 1, 2024 18:51
@jchristgit jchristgit self-assigned this Sep 1, 2024
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also add role::postfix to the handlers

@jchristgit
Copy link
Member

Banks shoots, Banks Scores!

@jb3
Copy link
Member Author

jb3 commented Sep 1, 2024

We should probably also add role::postfix to the handlers

Hmmm, we don't for other ones.

I believe the reason is that if we want to use a role as a dependency then
adding tags onto it stops the handlers running properely if the handlers
that have been notified are from a dependency that's not been tagged?

@jchristgit
Copy link
Member

jchristgit commented Sep 2, 2024 via email

@jb3
Copy link
Member Author

jb3 commented Sep 3, 2024

Hmm, well they run right now without tags, and of course run with tags, and they'll only ever run if called from a task which does have a tag.

@jchristgit
Copy link
Member

jchristgit commented Sep 3, 2024 via email

We don't want to rewrite the envelopes of mail that is from a valid
domain of our mailserver (e.g. pydis.com or int.pydis.wtf), but by
default PostSRSD will rewrite anything that is not the `mydomain`
configuration variable of Postfix (which is just set to `pydis.wtf` for
us).

This change updates the environment defaults for PostSRSD to ensure that
we don't change any envelopes that don't need to be changed, as well as
ensuring that to end mailservers the DKIM and SPF checks are made
against the actual domain (e.g. int.pydis.wtf) instead of the rewritten
envelope.
@jb3 jb3 force-pushed the jb3/mail/postsrsd-excludes branch from 72af488 to 0c12eb5 Compare September 3, 2024 18:48
@jb3 jb3 merged commit 0c12eb5 into main Sep 3, 2024
6 checks passed
@jb3 jb3 deleted the jb3/mail/postsrsd-excludes branch September 3, 2024 18:48
Copy link

github-actions bot commented Sep 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: email Issues relating to our email forwarding system, hosted on our netcup machines. group: ansible Issues and pull requests related to the Ansible setup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants