Skip TestLeaks when GREENLET_SKIP_LEAKCHECKS is used#461
Closed
mgorny wants to merge 1 commit intopython-greenlet:masterfrom
Closed
Skip TestLeaks when GREENLET_SKIP_LEAKCHECKS is used#461mgorny wants to merge 1 commit intopython-greenlet:masterfrom
TestLeaks when GREENLET_SKIP_LEAKCHECKS is used#461mgorny wants to merge 1 commit intopython-greenlet:masterfrom
Conversation
When `GREENLET_SKIP_LEAKCHECKS` is used, we do not want to check for leaks, and therefore it makes no sense to run tests explicitly checking for leaks. Since the conditional is also true for MANYLINUX builds, remove the redundant condition.
Contributor
Author
|
For the record, I'm not 100% sure if I understand the purpose of |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 31, 2025
Skip checking for leaks and running leak checks in the ebuild. They are slow, technically fragile and only really reliable for upstream testing. And they crash on JIT builds. Bug: python-greenlet/greenlet#455 Pull-Request: python-greenlet/greenlet#461 Signed-off-by: Michał Górny <mgorny@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
GREENLET_SKIP_LEAKCHECKSis used, we do not want to check for leaks, and therefore it makes no sense to run tests explicitly checking for leaks. Since the conditional is also true for MANYLINUX builds, remove the redundant condition.