-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to require POST only authentication requsts #493
Add configuration to require POST only authentication requsts #493
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 93.99% 94.07% +0.07%
==========================================
Files 39 39
Lines 1116 1131 +15
Branches 129 133 +4
==========================================
+ Hits 1049 1064 +15
Misses 43 43
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
0d9f10b
to
59f1e42
Compare
Merged, thanks for your contribution! |
@nijel I will also create a PR to update Django specific configuration documentation. |
To reflect Django configuration changes related to python-social-auth/social-app-django#493 this PR adds notes about using `SOCIAL_AUTH_REQUIRE_POST` configuration
To reflect Django configuration changes related to python-social-auth/social-app-django#493 this PR adds notes about using `SOCIAL_AUTH_REQUIRE_POST` configuration
Proposed changes
This PR introduces a new configuration and authentication behaviour when it is active and will require POST request during authentication
SOCIAL_AUTH_REQUIRE_POST: bool
,POST
.Types of changes
Please check the type of change your PR introduces:
Related issues and discussions
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.