Fix ImportError: cannot import name 'JSONField' from 'social_django.fields' when JSONFIELD_CUSTOM is set #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting JSONFIELD_CUSTOM the logic was importing under the wrong name with `Base` suffix raising `Import Error` as the module ended up having no `JSONField` to be imported. Looks like due toa recent change the JSONFieldBase` is no more needed.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #502 +/- ##
=======================================
Coverage 93.99% 93.99%
=======================================
Files 39 39
Lines 1116 1116
Branches 129 129
=======================================
Hits 1049 1049
Misses 43 43
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting JSONFIELD_CUSTOM the logic was importing under the wrong name with
Basesuffix raisingImport Erroras the module ended up having noJSONFieldto be imported.Looks like due to a recent change the JSONFieldBase` is no more needed.