Avoid raising errors on malformed POST data #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 94.07% 94.11% +0.04%
==========================================
Files 39 39
Lines 1131 1139 +8
Branches 133 133
==========================================
+ Hits 1064 1072 +8
Misses 43 43
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nijel
reviewed
Oct 3, 2023
tests/test_context_processors.py
Outdated
| @@ -19,3 +19,15 @@ def test_login_redirect_unicode_quote(self): | |||
| "REDIRECT_QUERYSTRING": "next=profile/sj%C3%B3", | |||
| }, | |||
| ) | |||
|
|
|||
| def test_login_redirect_malformed_post(self): | |||
| request = self.request_factory.post("/", data="no boundary", content_type="multipart/form-data") | |||
There was a problem hiding this comment.
Needs formatting, see https://results.pre-commit.ci/run/github/69119240/1696338661.I5RZqwrgRPmTEG5Or7dWkw (or enable editing of the PR and pre-commit.ci will do the fixes for you).
There was a problem hiding this comment.
Sorry, forgot to setup pre-commit locally.
sevdog
force-pushed
the
fix-potential-post-errors
branch
from
55ffdb7
to
36ac3e8
Compare
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
login_redirectcontext-processor relies onrequest.POSTdata to retrive the redirect field value.If by any means the django app is serving a malformed multipart request (ie:
Content-Type: multipart/form-datawithout a proper form-boundary) it will raise a multipart error. Since this context-processor is advised to be used in the default template configuration it will cause a 500 response (internal server error) due to the un-catched exception.Types of changes
Please check the type of change your PR introduces:
Checklist