Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations: optimize extra_data migration #520

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 17, 2023

Proposed changes

This makes it more friendly to huge databases.

Fixes #501

Types of changes

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

This makes it more friendly to huge databases.

Fixes python-social-auth#501
@nijel nijel enabled auto-merge (rebase) October 17, 2023 07:16
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a8713fa) 94.12% compared to head (36c3e59) 93.63%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   94.12%   93.63%   -0.49%     
==========================================
  Files          39       39              
  Lines        1140     1147       +7     
  Branches      136      138       +2     
==========================================
+ Hits         1073     1074       +1     
- Misses         43       48       +5     
- Partials       24       25       +1     
Flag Coverage Δ
unittests 93.63% <11.11%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ocial_django/migrations/0013_migrate_extra_data.py 29.41% <11.11%> (-3.93%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nijel nijel merged commit c2f7604 into python-social-auth:master Oct 17, 2023
7 of 9 checks passed
@nijel nijel deleted the migrate branch October 17, 2023 07:21
@nijel nijel self-assigned this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5.3.0 migrations feedback
1 participant